Skip to content

UI : Fix SSL certificate submit button not working#5682

Merged
yadvr merged 5 commits intoapache:4.16from
ablecloud-team:ui-ssl-certificates-bug
Nov 18, 2021
Merged

UI : Fix SSL certificate submit button not working#5682
yadvr merged 5 commits intoapache:4.16from
ablecloud-team:ui-ssl-certificates-bug

Conversation

@dhslove
Copy link
Copy Markdown
Contributor

@dhslove dhslove commented Nov 12, 2021

Description

This PR fixes an issue where clicking the Submit button in the SSL Certificates dialog in the Infrastructure Summary UI did not work.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

image

How Has This Been Tested?

@Pearl1594
Copy link
Copy Markdown
Contributor

Pearl1594 commented Nov 12, 2021

@blueorangutan ui

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Nov 12, 2021

@Pearl1594 a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Nov 12, 2021

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5682 (SL-JID-821)

Pearl1594
Pearl1594 approved these changes Nov 12, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@Pearl1594 Pearl1594 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

utchoang
utchoang approved these changes Nov 15, 2021
View reviewed changes
Copy link
Copy Markdown

@utchoang utchoang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yadvr yadvr changed the base branch from main to 4.16 November 15, 2021 08:39
@yadvr yadvr added this to the 4.16.1.0 milestone Nov 15, 2021
@yadvr
Copy link
Copy Markdown
Member

yadvr commented Nov 15, 2021

LGTM, @dhslove can you rebase to 4.16 branch - much needed fix towards 4.16.1

nvazquez and others added 3 commits November 16, 2021 17:10
@dhslove dhslove force-pushed the ui-ssl-certificates-bug branch from 9b3e3ea to db04396 Compare November 16, 2021 08:14
@dhslove
Copy link
Copy Markdown
Contributor Author

dhslove commented Nov 16, 2021

LGTM, @dhslove can you rebase to 4.16 branch - much needed fix towards 4.16.1

Rebased to 4.16.

@shwstppr
Copy link
Copy Markdown
Contributor

shwstppr commented Nov 16, 2021

@blueorangutan ui

1 similar comment
@yadvr
Copy link
Copy Markdown
Member

yadvr commented Nov 17, 2021

@blueorangutan ui

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Nov 17, 2021

@rhtyd a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Nov 17, 2021

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5682 (SL-JID-832)

@GabrielBrascher
Copy link
Copy Markdown
Member

GabrielBrascher commented Nov 17, 2021

➡️ Not related only to this PR:

UI build: heavy_check_mark Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5682 (SL-JID-832)

I am having trouble to log in into thee qa.cloudstack.cloud recently. Is it just me?

Error
Exception caught while discovering features

Responses look good (OK 200). But there is the above error message.

@yadvr
Copy link
Copy Markdown
Member

yadvr commented Nov 18, 2021

I'll check and restart it @GabrielBrascher

@yadvr yadvr merged commit a8e7315 into apache:4.16 Nov 18, 2021
@hstan77
Copy link
Copy Markdown

hstan77 commented Jan 10, 2022

I am facing the same issue , i installed on Ubuntu 20, do I need to do wait for 4.16.1 ? or any patch to solve this .

@DaanHoogland
Copy link
Copy Markdown
Contributor

DaanHoogland commented Jan 10, 2022

@hstan77 If you can patch yourself you can apply the commit in a8e7315

@hstan77
Copy link
Copy Markdown

hstan77 commented Jan 10, 2022

@DaanHoogland this is patch to the source and recompile it right ?

@DaanHoogland
Copy link
Copy Markdown
Contributor

DaanHoogland commented Jan 10, 2022

It is part of the source for the UI yes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Pearl1594 Pearl1594 Pearl1594 approved these changes

@utchoang utchoang utchoang approved these changes

@davidjumani davidjumani Awaiting requested review from davidjumani

Assignees

No one assigned

Labels

None yet

Projects

No open projects
Apache CloudStack 4.16.1
Status: Done

Milestone

4.16.1.0

Development

Successfully merging this pull request may close these issues.